Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import multiple segmentations from coco format json #251

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

Ljung323
Copy link
Contributor

@Ljung323 Ljung323 commented Jun 19, 2024

Issue

#246

Changes

  • d5287ad pass all segmentation items to create_segmentation function
  • 3b76299 fix the content of help

Test

original image with segmentation

before change: only 1 section is imported

after change: all 5 sections are imported

@github-actions github-actions bot added the fix label Jun 19, 2024
@Ljung323 Ljung323 marked this pull request as ready for review June 19, 2024 02:07
@niklub niklub requested a review from makseq June 19, 2024 12:29
@makseq
Copy link
Member

makseq commented Aug 5, 2024

@Ljung323 Could you please update your branch and merge the lastest master branch from the main repo?

@makseq
Copy link
Member

makseq commented Aug 5, 2024

@Ljung323 Is it possible to add test for coco import? Something like this: https://github.com/Ljung323/label-studio-sdk/blob/master/tests/custom/converter/test_import_yolo.py

You can merely run the converter on a real simple COCO json, get its output and use it for test assertion. It would be wonderful to have it.

Copy link
Member

@makseq makseq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please update to the latest master branch
  2. Could you add a test?

@Ljung323
Copy link
Contributor Author

Ljung323 commented Aug 6, 2024

@makseq
Thank you very much for the review.

I updated the code:

  1. Please update to the latest master branch

92f6927

  1. Could you add a test?

a3c8ba7 da9abcb

@Ljung323 Ljung323 requested a review from makseq August 6, 2024 07:58
@makseq makseq changed the title fix: import multiple segmentations from coco format json fix: Import multiple segmentations from coco format json Aug 7, 2024
@makseq makseq merged commit 01937c8 into HumanSignal:master Aug 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants