Close VNC connection on drop

[wbenny]

Hi!

If the VNC server closes the connection (e.g. VM or physical machine gets shut down), and the user doesn't call VncClient::close() manually, the async_connection_process_loop() get stuck in an infinite loop - because stop_ch is never triggered.

I would argue that it shouldn't be a user's responsibility to call a close() call - in similar vein that it's not a user's responsibility to call close on File or TcpStream.

This PR adds call to the VncInner::close() on Drop of VncInner to prevent a leak of a task that uses 100% of the CPU core.

[HsuJv]

Thanks for the patch. I didn't think this through very well.

[HsuJv]

'''
I would argue that it shouldn't be a user's responsibility to call a close() call - in similar vein that it's not a user's responsibility to call close on File or TcpStream.
'''

I agree with that and am currently working on this. Will have a new release when done.

[HsuJv]

This commit shall now fix the close issue
8c50710

BRs.

[wbenny]

You're the best! Thanks!