Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable-ruby 3.4.1 #269

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

portable-ruby 3.4.1 #269

wants to merge 4 commits into from

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Dec 25, 2024

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@p-linnane
Copy link
Member

Updated the test per https://bugs.ruby-lang.org/issues/20433

@Bo98
Copy link
Member

Bo98 commented Dec 25, 2024

Hmm, the livecheck intentionally skips .0 and instead matches .1+ releases to avoid the first release in December and to opt for the next release in February/whatever. In this case .1 happened to be the first real release here due to a release issue.

I'm ok opting for 3.4 earlier than planned but I'd rather still wait a little bit before actually merging (we don't necessarily have to wait for 3.4.2 if there's no known issues).

@Bo98
Copy link
Member

Bo98 commented Dec 25, 2024

This has however been useful in revealing a bug on older macOS so will look into upstreaming a fix for that.

We'll also need to look into vendoring base64 in brew first too.

@p-linnane
Copy link
Member

No real rush here. I just wanted to see if we'd have any build issues, especially with the base64 removal.

@p-linnane
Copy link
Member

Should we also change pkg-config to pkgconf here?

@Bo98
Copy link
Member

Bo98 commented Dec 26, 2024

Should we also change pkg-config to pkgconf here?

I don't mind either way. It's an alias so both work.

We added a blanket audit exception for non-core taps and it's unlikely we'll ever remove it.

@p-linnane p-linnane force-pushed the bump-portable-ruby-3.4.1 branch from 5c097ef to b86e1dc Compare December 26, 2024 03:48
@p-linnane
Copy link
Member

Built fine for me locally with Homebrew/brew#19004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants