whisper-cpp: make compatible with --HEAD install
#202270
Conversation
mislav
force-pushed
the
whisper-cpp-head
branch
from
a7ac849 to
0fd2a7e
Compare
| system "cmake", "--build", "build", "--target", "main" | ||
| bin.install "build/bin/main" => "whisper-cpp" | ||
| # avoid installing libggml libraries to "lib" since they would conflict with llama.cpp | ||
| system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args(install_libdir: "libinternal") |
There was a problem hiding this comment.
| system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args(install_libdir: "libinternal") | |
| system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args(install_libdir: "lib/ggml") |
Maybe? You'll need to adjust the argument to #rpath from my suggestion above if you apply this. (to rpath(target: lib/"ggml")).
Though, ideally we should be using libggml from llama.cpp instead (or vice-versa).
There was a problem hiding this comment.
Though, ideally we should be using
libggmlfromllama.cppinstead (or vice-versa).
I've suggested this with maintainers of libggml/llama.cpp/whisper.cpp and they said that could be an eventual goal but that the codebases aren't ready for that at this moment since libggml seems to be such a fast-moving target.
Formula/w/whisper-cpp.rb
Outdated
| (bin/"whisper-cpp").write <<~EOS | ||
| #!/bin/bash | ||
| here="${BASH_SOURCE[0]}" | ||
| echo "${BASH_SOURCE[0]}: warning: whisper-cpp is deprecated. Use whisper-cli instead." >&2 | ||
| exec "$(dirname "$here")/whisper-cli" "$@" | ||
| EOS | ||
| (bin/"whisper-cpp").chmod 0755 |
There was a problem hiding this comment.
We should probably do this unconditionally?
This is to accommodate the build system changes in the upcoming v1.7.4
mislav
force-pushed
the
whisper-cpp-head
branch
from
0fd2a7e to
b9990f9
Compare
|
@carlocab Thanks for the detailed review; I've addressed the comments. |
This is to accommodate the build system changes in the upcoming v1.7.4 release.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?In
--HEADmode, the main changes are that dylibs are now enabled and that the main binary is now calledwhisper-cli.Libraries and header files currently unfortunately conflict with the
llama.cppformula, so in this installation we rename the "lib" folder and omit the header files to avoid the conflict. ggerganov/ggml#1050 (comment)