Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handbrake 1.9.0 #202074

Closed
wants to merge 1 commit into from
Closed

handbrake 1.9.0 #202074

wants to merge 1 commit into from

Conversation

Mr-TTOT
Copy link

@Mr-TTOT Mr-TTOT commented Dec 21, 2024

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 21, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@alebcay
Copy link
Member

alebcay commented Dec 21, 2024

The vendored copy of SVT-AV1 is failing to build:

  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:139:21: error: always_inline function 'vusmmlaq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve6_4_h' that is compiled without support for 'i8mm'
    139 |     int32x4_t sum = vusmmlaq_s32(vdupq_n_s32(0), perm_samples, filter);
        |                     ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:154:25: error: always_inline function 'vusmmlaq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve6_8_h' that is compiled without support for 'i8mm'
    154 |     int32x4_t sum0123 = vusmmlaq_s32(vdupq_n_s32(0), perm_samples[0], filter);
        |                         ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:155:25: error: always_inline function 'vusmmlaq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve6_8_h' that is compiled without support for 'i8mm'
    155 |     int32x4_t sum4567 = vusmmlaq_s32(vdupq_n_s32(0), perm_samples[1], filter);
        |                         ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:50:21: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_4_h' that is compiled without support for 'i8mm'
     50 |     int32x4_t sum = vusdotq_lane_s32(vdupq_n_s32(0), permuted_samples[0], filters, 0);
        |                     ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:51:21: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_4_h' that is compiled without support for 'i8mm'
     51 |     sum           = vusdotq_lane_s32(sum, permuted_samples[1], filters, 1);
        |                     ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:68:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_h' that is compiled without support for 'i8mm'
     68 |     int32x4_t sum0 = vusdotq_lane_s32(vdupq_n_s32(0), permuted_samples[0], filters, 0);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:69:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_h' that is compiled without support for 'i8mm'
     69 |     sum0           = vusdotq_lane_s32(sum0, permuted_samples[1], filters, 1);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:71:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_h' that is compiled without support for 'i8mm'
     71 |     int32x4_t sum1 = vusdotq_lane_s32(vdupq_n_s32(0), permuted_samples[1], filters, 0);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:72:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_h' that is compiled without support for 'i8mm'
     72 |     sum1           = vusdotq_lane_s32(sum1, permuted_samples[2], filters, 1);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:293:21: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_4_v' that is compiled without support for 'i8mm'
    293 |     int32x4_t sum = vusdotq_lane_s32(vdupq_n_s32(0), samples_lo, filters, 0);
        |                     ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:294:21: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_4_v' that is compiled without support for 'i8mm'
    294 |     sum           = vusdotq_lane_s32(sum, samples_hi, filters, 1);
        |                     ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:306:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_v' that is compiled without support for 'i8mm'
    306 |     int32x4_t sum0 = vusdotq_lane_s32(vdupq_n_s32(0), samples0_lo, filters, 0);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:307:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_v' that is compiled without support for 'i8mm'
    307 |     sum0           = vusdotq_lane_s32(sum0, samples0_hi, filters, 1);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:309:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_v' that is compiled without support for 'i8mm'
    309 |     int32x4_t sum1 = vusdotq_lane_s32(vdupq_n_s32(0), samples1_lo, filters, 0);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  /tmp/handbrake-20241221-7302-j80h7j/HandBrake-1.9.0/build/contrib/svt-av1/SVT-AV1-v2.3.0/Source/Lib/ASM_NEON_I8MM/aom_convolve8_neon_i8mm.c:310:22: error: always_inline function 'vusdotq_s32' requires target feature 'i8mm', but would be inlined into function 'convolve8_8_v' that is compiled without support for 'i8mm'
    310 |     sum1           = vusdotq_lane_s32(sum1, samples1_hi, filters, 1);
        |                      ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/arm_neon.h:35960:15: note: expanded from macro 'vusdotq_lane_s32'
   35960 |   __ret_157 = vusdotq_s32(__s0_157, __s1_157, (int8x16_t)(splatq_lane_s32(*(int32x2_t *) &__reint_157, __p3_157))); \
         |               ^
  15 errors generated.
  make[3]: *** [Source/Lib/ASM_NEON_I8MM/CMakeFiles/ASM_NEON_I8MM.dir/aom_convolve8_neon_i8mm.c.o] Error 1
  make[2]: *** [Source/Lib/ASM_NEON_I8MM/CMakeFiles/ASM_NEON_I8MM.dir/all] Error 2
  make[1]: *** [all] Error 2
  make: *** [contrib/svt-av1/.stamp.svt-av1.build] Error 2
  make: *** Waiting for unfinished jobs....

The vendored copy is 2.3.0, the latest in Homebrew is 2.2.1. We encountered similar, if not the same, error here when attempting to build 2.3.0 in Homebrew.

@alebcay alebcay added the build failure CI fails while building the software label Dec 21, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Dec 24, 2024
@github-actions github-actions bot closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants