Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: remove misleading comment in go.env #202031

Merged
merged 2 commits into from
Dec 21, 2024
Merged

go: remove misleading comment in go.env #202031

merged 2 commits into from
Dec 21, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See #202030 and golang/go#70949.

In particular, our current go.env contains

# Automatically download newer toolchains as directed by go.mod files.
# See https://go.dev/doc/toolchain for details.
GOTOOLCHAIN=local

The comment about automatically downloading newer toolchains applies
only whenever GOTOOLCHAIN=auto, but we change that to
GOTOOLCHAIN=local. Therefore, let's get rid of the comment that no
longer applies after our GOTOOLCHAIN change.

See #202030 and golang/go#70949.

In particular, our current `go.env` contains

    # Automatically download newer toolchains as directed by go.mod files.
    # See https://go.dev/doc/toolchain for details.
    GOTOOLCHAIN=local

The comment about automatically downloading newer toolchains applies
only whenever `GOTOOLCHAIN=auto`, but we change that to
`GOTOOLCHAIN=local`. Therefore, let's get rid of the comment that no
longer applies after our `GOTOOLCHAIN` change.
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 21, 2024
Merged via the queue into master with commit 0ee335d Dec 21, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the go.env branch December 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants