Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwok: fix base_name for shell completion #201868

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added go Go use is a significant feature of the PR or issue shell-completion labels Dec 20, 2024
@cho-m
Copy link
Member

cho-m commented Dec 20, 2024

Should do the reverse and remove most base_name usage - Homebrew/brew#18942

e.g. #201871

@chenrui333
Copy link
Member Author

yeah, that is a better idea.

@chenrui333 chenrui333 closed this Dec 20, 2024
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Dec 20, 2024
@github-actions github-actions bot deleted the kwok-completion branch December 20, 2024 04:56
@cho-m
Copy link
Member

cho-m commented Dec 20, 2024

For kwok, either can wait for next bump PR or can rebuild bottle.

EDIT: Also, formulae that still need base_name are mainly the ones that use register-python-argcomplete (e.g. python-yq, commitizen, and azure-cli). If the number increase enough, can add logic to handle in brew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue shell-completion superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants