-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] 2.17 (new formula) #197951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but making sure unversioned glibc
works in aarch64 is required for us to use this so worth checking that it does (the bootstrap stuff can however come later).
Since we don't really have any aarch64 Linux bottles, is there anything that we should test in particular? I did conduct some very basic testing, and I can do more some more extensive ones later. With binaries from Homebrew/glibc-bootstrap#31, I bootstrapped the unversioned I haven't tested building formulae from source yet as I had to first build GCC and all its dependencies from source which was a bit too heavy for a quick test in Docker on a Raspberry Pi. (For the same reason I used |
That test seems fine to me. If |
This is part of the effort to bring Portable Ruby (and perhaps Homebrew) to AArch64 Linux. 2.17 is the first glibc version that supports AArch64 [1]. As discussed previously [2], this formula will allow us to later build Portable Ruby against this version of glibc for maximum coverage of Linux distributions on AArch64. [1]: https://sourceware.org/glibc/wiki/Release/2.17 [2]: Homebrew/homebrew-portable-ruby#212
b11186d
to
5176d76
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This is part of the effort to bring Portable Ruby (and perhaps Homebrew) to AArch64 Linux.
2.17 is the first glibc version that supports AArch64 1. As discussed previously 2, this formula will allow us to later build Portable Ruby against this version of glibc for maximum coverage of Linux distributions on AArch64.
Footnotes
https://sourceware.org/glibc/wiki/Release/2.17 ↩
https://github.com/Homebrew/homebrew-portable-ruby/pull/212 ↩