Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] 2.17 (new formula) #197951

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[email protected] 2.17 (new formula) #197951

merged 2 commits into from
Nov 25, 2024

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is part of the effort to bring Portable Ruby (and perhaps Homebrew) to AArch64 Linux.

2.17 is the first glibc version that supports AArch64 1. As discussed previously 2, this formula will allow us to later build Portable Ruby against this version of glibc for maximum coverage of Linux distributions on AArch64.

Footnotes

  1. https://sourceware.org/glibc/wiki/Release/2.17

  2. https://github.com/Homebrew/homebrew-portable-ruby/pull/212

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula linux-only Formula depends on Linux labels Nov 16, 2024
@ZhongRuoyu ZhongRuoyu requested a review from Bo98 November 16, 2024 22:56
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but making sure unversioned glibc works in aarch64 is required for us to use this so worth checking that it does (the bootstrap stuff can however come later).

Formula/g/[email protected] Outdated Show resolved Hide resolved
@ZhongRuoyu
Copy link
Member Author

making sure unversioned glibc works in aarch64 is required for us to use this so worth checking that it does

Since we don't really have any aarch64 Linux bottles, is there anything that we should test in particular? I did conduct some very basic testing, and I can do more some more extensive ones later.

With binaries from Homebrew/glibc-bootstrap#31, I bootstrapped the unversioned glibc 2.35 on CentOS 7 (system glibc version 2.17), and tested a handful of bottles there (hello, xz, gzip, ...), that were built on another Ubuntu 22.04 system with system glibc 2.35.

I haven't tested building formulae from source yet as I had to first build GCC and all its dependencies from source which was a bit too heavy for a quick test in Docker on a Raspberry Pi. (For the same reason I used --ignore-dependencies to install the bottles.)

@Bo98
Copy link
Member

Bo98 commented Nov 17, 2024

Since we don't really have any aarch64 Linux bottles, is there anything that we should test in particular? I did conduct some very basic testing, and I can do more some more extensive ones later.

With binaries from Homebrew/glibc-bootstrap#31, I bootstrapped the unversioned glibc 2.35 on CentOS 7 (system glibc version 2.17), and tested a handful of bottles there (hello, xz, gzip, ...), that were built on another Ubuntu 22.04 system with system glibc 2.35.

That test seems fine to me. If glibc builds fine and is usable then that sounds good to me.

This is part of the effort to bring Portable Ruby (and perhaps Homebrew)
to AArch64 Linux.

2.17 is the first glibc version that supports AArch64 [1]. As discussed
previously [2], this formula will allow us to later build Portable Ruby
against this version of glibc for maximum coverage of Linux
distributions on AArch64.

[1]: https://sourceware.org/glibc/wiki/Release/2.17
[2]: Homebrew/homebrew-portable-ruby#212
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 8ac3d70 Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. legacy Relates to a versioned @ formula linux-only Formula depends on Linux new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants