Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foot 1.18.1 (new formula) #192675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david
Copy link

@david david commented Oct 2, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core linux-only Formula depends on Linux labels Oct 2, 2024
@david david force-pushed the add-formula-for-foot-terminal-linux-only branch from 8ac1287 to d115f64 Compare October 2, 2024 21:57
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@david david force-pushed the add-formula-for-foot-terminal-linux-only branch from d115f64 to 4f2a579 Compare October 2, 2024 22:02
Comment on lines 14 to 19
depends_on "fontconfig"
depends_on "libxkbcommon"
depends_on :linux
depends_on "pixman"
depends_on "wayland"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add depends_on "freetype"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 done, thanks.

@david david force-pushed the add-formula-for-foot-terminal-linux-only branch from 4f2a579 to 889665c Compare October 3, 2024 09:15
@david david requested a review from chenrui333 October 3, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux-only Formula depends on Linux new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants