Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libarchive 3.7.6 #191588

Merged
merged 4 commits into from
Sep 25, 2024
Merged

libarchive 3.7.6 #191588

merged 4 commits into from
Sep 25, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Sep 23, 2024
@chenrui333 chenrui333 added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Sep 23, 2024
@carlocab carlocab added long dependent tests Set a long timeout for dependent testing CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Sep 23, 2024
@carlocab
Copy link
Member

lanraragi is failing again on Intel macOS. I guess we can try the same fix as last time...

@carlocab carlocab force-pushed the bump-libarchive-3.7.6 branch from 0c28bba to f5a4f49 Compare September 23, 2024 20:29
@carlocab carlocab removed the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
@carlocab carlocab force-pushed the bump-libarchive-3.7.6 branch from f5a4f49 to da05713 Compare September 24, 2024 09:53
@github-actions github-actions bot added the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
@carlocab carlocab added long dependent tests Set a long timeout for dependent testing and removed CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing labels Sep 24, 2024
@carlocab
Copy link
Member 

  ==> Verifying attestation for cpanminus
  Error: The bottle for cpanminus has an invalid build provenance attestation.
  
  This may indicate that the bottle was not produced by the expected
  tap, or was maliciously inserted into the expected tap's bottle
  storage.
  
  Additional context:
  
  no attestation matches subject: 2bedd86921800fbcd2c3417ce8ae1a3f46330efa8aeadef25dcc2ab5c128676f--cpanminus--1.7047.arm64_ventura.bottle.tar.gz

carlocab added a commit that referenced this pull request Sep 24, 2024
@carlocab
cpanminus: regenerate attestations, build :all bottle
3ff77ae 
This formula has a bunch of `/usr/local` references that may as well be
`HOMEBREW_PREFIX` references. We also build with Homebrew `perl` to
ensure that embedded versions refereces in the manpages are the same.

Also fixes an attestation verification failure spotted at #191588.
@carlocab carlocab mentioned this pull request Sep 24, 2024
Merged
6 tasks
@carlocab
Copy link
Member

Fix in #191709.

@carlocab carlocab force-pushed the bump-libarchive-3.7.6 branch from da05713 to 8a6daa6 Compare September 24, 2024 12:25
@github-actions github-actions bot added the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
@carlocab carlocab removed CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner long dependent tests Set a long timeout for dependent testing labels Sep 24, 2024
@cho-m
Copy link
Member

cho-m commented Sep 24, 2024 •
edited
Loading

lanraragi is failing again on Intel macOS. I guess we can try the same fix as last time...

If it only fails on Intel macOS, then we are probably using a bundled libarchive on ARM macOS - https://metacpan.org/pod/Alien::Libarchive3#DESCRIPTION

It does this by first trying to detect an existing install of libarchive on your system. If found it will use that. If it cannot be found, the source code will be downloaded from the internet and it will be installed in a private share location for the use of other modules.

And for Intel macOS, may be pkg-config Cellar paths again - Homebrew/brew#18229

@carlocab
Copy link
Member

If it only fails on Intel macOS, then we are probably using a bundled libarchive on ARM macOS - metacpan.org/pod/Alien::Libarchive3#DESCRIPTION

How do we convince it to use our libarchive?

And for Intel macOS, may be pkg-config Cellar paths again - Homebrew/brew#18229

Yea, we should really fix that in brew already.

@carlocab carlocab force-pushed the bump-libarchive-3.7.6 branch from 8a6daa6 to cea0d28 Compare September 24, 2024 14:21
@github-actions github-actions bot added the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
@carlocab carlocab removed the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
@cho-m
Copy link
Member

cho-m commented Sep 24, 2024 •
edited
Loading

How do we convince it to use our libarchive?

Not sure. It looks like it should have found it via PKG_CONFIG_PATH (https://github.com/uperl/Alien-Libarchive3/blob/v0.33/alienfile#L5). There is some extra logic for Intel macOS paths, which should have been a no-op if our environment variable was used.

However, the ARM bottle has the bundled libs:

lanraragi/0.9.21_1/libexec/lib/perl5/darwin-thread-multi-2level/auto/share/dist/Alien-Libarchive3/dynamic/libarchive.13.dylib
lanraragi/0.9.21_1/libexec/lib/perl5/darwin-thread-multi-2level/auto/share/dist/Alien-Libarchive3/dynamic/libarchive.dylib
lanraragi/0.9.21_1/libexec/lib/perl5/darwin-thread-multi-2level/auto/share/dist/Alien-Libarchive3/dynamic/libarchive.la

BrewTestBot and others added 2 commits September 24, 2024 22:47
@BrewTestBot @carlocab
libarchive 3.7.6
a6941f9 
Co-authored-by: Carlo Cabrera <[email protected]>
@carlocab
lanraragi: revision bump (libarchive 3.7.6)
8570b67 
Co-authored-by: Carlo Cabrera <[email protected]>
@carlocab carlocab force-pushed the bump-libarchive-3.7.6 branch from cea0d28 to 8570b67 Compare September 24, 2024 14:52
@github-actions github-actions bot added the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
@carlocab carlocab removed the CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner label Sep 24, 2024
carlocab
carlocab approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing bottle attestations are being handled elsewhere. Merging.

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 25, 2024
Merged via the queue into master with commit c6aa7d4 Sep 25, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-libarchive-3.7.6 branch September 25, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrewTestBot @carlocab @cho-m @chenrui333