Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-boto3 python-botocore python-jmespath python-s3transfer: remove #163229

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 19, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Draft as we may need official documentation (e.g. Homebrew/brew#16662) before any actual deprecation/removal.

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Feb 19, 2024
@github-actions github-actions bot added the formula deprecated Formula deprecated label Feb 19, 2024
Formula/p/python-boto3.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 changed the title python-boto3 python-botocore python-jmespath python-s3transfer: deprecate python-boto3 python-botocore python-jmespath python-s3transfer: remove Feb 19, 2024
@github-actions github-actions bot added marked for removal/rejection PR is probably going to be closed or formula deleted and removed formula deprecated Formula deprecated labels Feb 19, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 20, 2024
@cho-m cho-m marked this pull request as ready for review February 20, 2024 13:59
@cho-m cho-m added the maintainer feedback Additional maintainers' opinions may be needed label Feb 20, 2024
@iMichka iMichka removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 20, 2024
@iMichka
Copy link
Member

iMichka commented Feb 20, 2024

Agreed, let's merge this. People can still use pip install to get the same resulting packages.

@iMichka iMichka added this pull request to the merge queue Feb 20, 2024
@p-linnane p-linnane removed the maintainer feedback Additional maintainers' opinions may be needed label Feb 20, 2024
Merged via the queue into Homebrew:master with commit 957cabd Feb 20, 2024
22 checks passed
@cho-m cho-m deleted the deprecate-boto3 branch February 20, 2024 20:05
@chenrui333 chenrui333 added the python-vendoring Part of the Python resource vendoring project label Feb 20, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. marked for removal/rejection PR is probably going to be closed or formula deleted outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants