-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Backblaze Uninstaller and switch to latest version as Backblaze downloads are unversioned #88039
Conversation
Backblaze do not offer versioned downloads of their installer so attempting to upgrade the Cask causes issues with mismatched checksums if the previous installer is still cached. This means we lose the ability to detect updates but forcibly upgrading the Cask (e.g. with `brew cask upgrade backblaze`) should now work as expected.
latest
version as Backblaze downloads are unversioned2a35d75
to
ff8a887
Compare
Rather than having to manually delete the various applications, preference panes and `launchctl` jobs installed by the Backblaze Installer ourselves, use the included Backblaze Uninstaller script instead. Note that the Uninstaller will not delete user-specific files so we retain the existing zap stanza.
ff8a887
to
8f1c0fd
Compare
"#{appdir}/Backblaze.app", | ||
"/Library/PreferencePanes/BackblazeBackup.prefPane", | ||
] | ||
uninstall script: "#{staged_path}/Backblaze Uninstaller.app/Contents/MacOS/Backblaze Uninstaller" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a script, it will call a GUI which complicates automation and which we do not want until we can do it properly.
|
||
url "https://secure.backblaze.com/mac/install_backblaze.dmg" | ||
appcast "https://secure.backblaze.com/api/clientversion.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole point of the appcast is that we can detect when updates are available. It’s never* correct to delete a functioning appcast.
* It can happen, but it’s so rare it happened maybe once in almost a decade.
@@ -1,23 +1,14 @@ | |||
cask "backblaze" do | |||
version "7.0.2.464" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s by having a version that brew upgrade
can work properly. You’re removing that ability.
The cask is correct as is. Everything you mentioned is done intentionally. |
Thanks for reviewing, @vitorgalvao. It's especially useful to know support for GUI uninstalls are a separate issue. Re the versioning of Backblaze: in retrospect, sacrificing the functioning Frustratingly, this is hard to reproduce due to the fact it's not possible to download an older version of the installer and I notice that all downloads in I'll re-test when a new version of the Backblaze installer is released to see if I can reproduce the problem more thoroughly then. |
Backblaze do not offer versioned downloads of their installer so attempting to upgrade the Cask causes issues with mismatched checksums if the previous installer is still cached.
This means we lose the ability to detect updates but forcibly upgrading the Cask (e.g. with
brew cask upgrade backblaze
) should now work as expected.Rather than having to manually delete the various applications, preference panes and
launchctl
jobs installed by the Backblaze Installer ourselves, use the included Backblaze Uninstaller script instead.Note that the Uninstaller will not delete user-specific files so we retain the existing zap stanza.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.