Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ayugram 5.8.3 (new cask) #196371

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ayugram 5.8.3 (new cask) #196371

wants to merge 5 commits into from

Conversation

loxetra
Copy link

@loxetra loxetra commented Dec 24, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @loxetra ! I left some comment and please take a look.

sha256 "7769048139324700659f73f52b703a65abfb71e6768edc3d3298473565a31849"

# Build from https://github.com/AyuGram/AyuGramDesktop/releases/download/v5.8.3/AyuGram.dmg
url "https://huggingface.co/loxtera/ayu-builds-temp/resolve/main/AyuGram.dmg?download=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to use the github url, which is versioned and more reliable.

# Build from https://github.com/AyuGram/AyuGramDesktop/releases/download/v5.8.3/AyuGram.dmg
url "https://huggingface.co/loxtera/ayu-builds-temp/resolve/main/AyuGram.dmg?download=true"
name "AyuGram"
desc "Is a Telegram client with ghost mode and message history"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc "Is a Telegram client with ghost mode and message history"
desc "Telegram client with ghost mode and message history"


app "AyuGram.app", target: "AyuGram Desktop.app"

zap trash: "~/Library/Application Support/AyuGram Desktop"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zap trash: "~/Library/Application Support/AyuGram Desktop"
zap trash: [
"~/Library/Application Support/AyuGram Desktop",
"~/Library/Saved Application State/one.ayugram.AyuGramDesktop.savedState",
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants