Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widgettoggler 1.2.0 (new cask) #194012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobbymannino
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Dec 3, 2024
@khipp khipp changed the title widgettoggler v1.2.0 widgettoggler 1.2.0 (new cask) Dec 3, 2024
@bevanjkay
Copy link
Member

bevanjkay commented Dec 4, 2024

Thank you for submitting this @bobbymannino
Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.

My other concern is that this hasn't been updated for over a year (no commits in the repo either), and a recent readme update suggests that the primary use case is no longer relevant.

sha256 "4a37bd84eb391c86e80a05b3b875dae6286418f2223970dbeff03abe310b5af9"

url "https://github.com/sieren/WidgetToggler/releases/download/#{version}/WidgetToggler_#{version.split(".")[0...2].join(".")}.zip"
name "widgettoggler"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name "widgettoggler"
name "WidgetToggler"

version "1.2.0"
sha256 "4a37bd84eb391c86e80a05b3b875dae6286418f2223970dbeff03abe310b5af9"

url "https://github.com/sieren/WidgetToggler/releases/download/#{version}/WidgetToggler_#{version.split(".")[0...2].join(".")}.zip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://github.com/sieren/WidgetToggler/releases/download/#{version}/WidgetToggler_#{version.split(".")[0...2].join(".")}.zip"
url "https://github.com/sieren/WidgetToggler/releases/download/#{version}/WidgetToggler_#{version.major_minor}.zip"

@daeho-ro daeho-ro added awaiting user reply Issue needs response from a user. and removed awaiting user reply Issue needs response from a user. labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing zap Cask is missing a zap stanza, please add one. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants