Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisdem-duplicate-finder: fix source issue #191831

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

yunhao-jiang
Copy link
Contributor

@yunhao-jiang yunhao-jiang commented Nov 13, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Fix source issue #172732

Also a quick question, if there's multiple source issue to fix, is it better to open separate pull request for each or can we open one pull request and includes all fix needed?

@yunhao-jiang yunhao-jiang marked this pull request as ready for review November 13, 2024 03:19
@khipp
Copy link
Member

khipp commented Nov 13, 2024

Also a quick question, if there's multiple source issue to fix, is it better to open separate pull request for each or can we open one pull request and includes all fix needed?

Ideally, submit one pull request per cask (see our style guide). It's fine to group changes if they are related, such as updating a cask and its @ variants. In these cases, each cask change should be in a separate commit.

Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yunhao-jiang!

@khipp khipp merged commit 52e1fbc into Homebrew:master Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants