Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various casks: update depends_on #187276

Merged
merged 12 commits into from
Oct 3, 2024

Conversation

AlternateRT
Copy link
Contributor

@AlternateRT AlternateRT commented Oct 2, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


These browsers are now based on Chromium 129 (or later), and as such require macOS 11 or later; this updates the depends_on stanza (and adds it to the microsoft-edge casks, where it was missing).

@bevanjkay bevanjkay added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Oct 3, 2024
@bevanjkay
Copy link
Member

We generally get this information from each app's info.plist file as this determines if an app can be run by the system.

It looks like not all the apps have been updated by the vendor to reflect this. Only the google-chrome-* seem to have been updated.

@AlternateRT
Copy link
Contributor Author

AlternateRT commented Oct 3, 2024

It looks like not all the apps have been updated by the vendor to reflect this. Only the google-chrome-* seem to have been updated.

@bevanjkay I was not aware of this. In any case, none of them will run of macOS 10.15 and all of them have announced elsewhere that macOS 11 is the new minimum requirement:

@AlternateRT
Copy link
Contributor Author

Hmm, I just had a look in each app's info.plist plist file, and they all had LSMinimumSystemVersion set to 11.0. Are you certain it was only the google-chrome-* apps? It looks to me like all vendors did in fact update it.

@AlternateRT
Copy link
Contributor Author

Is something wrong? There is a "syntax (macOS-15)" check, but it doesn't seem to be progressing at all.

@bevanjkay
Copy link
Member

bevanjkay commented Oct 3, 2024

Ahh the required checks were updated as we've moved to a newer CI image. Should be all good after rebasing.

@bevanjkay bevanjkay merged commit 44eca6d into Homebrew:master Oct 3, 2024
6 checks passed
@AlternateRT AlternateRT deleted the chromium-update-depends_on branch October 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants