.github/workflows/google-fonts.yml: fix changes check

[bevanjkay]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

[carlocab]

Seems like it should work as intended, barring a few edge cases. But I don't really follow how this was broken before this change so I can't judge how appropriate these changes are.

AFAICT they do the same thing, but I presume that's not true otherwise we wouldn't have this PR.

[bevanjkay]

I'll have a look through the comments in a bit, but this workflow hasn't worked correctly since all the workflows were reworked en-masse a couple of months ago.

[carlocab]

Suggested change

	git ls-files --modified --others -z | xargs -0 -I {} sh -c "
	FILENAME=\"{}\"
	MESSAGE=\$(basename \"\$FILENAME\" .rb)
	git add \"\$FILENAME\"
	git commit \"\$FILENAME\" --message=\"\$MESSAGE: \$MODE\" --message=\"\$COMMIT_BODY\""
	git ls-files --modified --others -z | xargs -0 -I {} sh -c '
	MESSAGE="$(basename "{}" .rb)"
	git add "{}"
	git commit "{}" --message="$MESSAGE: $MODE" --message="$COMMIT_BODY"'

You probably don't need all the escaping. If MODE and COMMIT_BODY are missing then try doing export MODE COMMIT_BODY before calling xargs

[carlocab]

Seems fine!