-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cask for Final Fantasy XIV #106950
Add cask for Final Fantasy XIV #106950
Conversation
I believe this has something to do with large file sizes, but I am not sure. |
Yeah, looking around I see a few reports of this error with similarly large files. The downloaded DMG is over INT32_MAX bytes. This might be a bug in brew itself, or one of its dependencies. I can't reproduce it here, unfortunately, but I'm on macOS 11, not 10.15 like this test runner is. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This reverts commit ca81e06.
After looking at #107214 which suggests the build check issue is intermittent, I think the check that failed is now passing. As a safety, I reran every command from the checklist above, including deleting the cached DMG and redownloading it. Every step worked as expected. |
Thank you @stevestreza. |
Adds the critically acclaimed MMORPG FINAL FANTASY XIV that has a free trial up to level 60 including the Heavensward expansion.
Reviewers: Please be advised if testing this cask, the downloaded DMG is approximately 2.5 GB.
:no_check
and go with a more semantic version.Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making all changes to a cask, verify:
brew audit --cask <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>
worked successfully.brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.