Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/livecheck: Skip autobumped formulae #18984

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

dev-cmd/livecheck: Skip autobumped formulae #18984

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f976ec
dev-cmd/livecheck: Skip autobumped formulae
issyl0 Dec 22, 2024
b54b9da
Oh the non-breaking space (option + space) got me again
issyl0 Dec 22, 2024
4b94bbb
More efficient autobump file reads - and support Casks
issyl0 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Library/Homebrew/dev-cmd/livecheck.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
Check for newer versions of formulae and/or casks from upstream.
If no formula or cask argument is passed, the list of formulae and
casks to check is taken from `HOMEBREW_LIVECHECK_WATCHLIST` or
`~/.homebrew/livecheck_watchlist.txt`.
`~/.homebrew/livecheck_watchlist.txt`, excluding autobumped formulae.
Copy link
Member

@samford samford Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add a way to disable this filtering behavior, this statement may not always be true. It may be better to simply leave out this added language (i.e., overarching assumptions about what livecheck will/won't check apply here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`~/.homebrew/livecheck_watchlist.txt`, excluding autobumped formulae.
`~/.homebrew/livecheck_watchlist.txt`.

EOS
switch "--full-name",
description: "Print formulae and casks with fully-qualified names."
Expand Down Expand Up @@ -90,6 +90,19 @@
end
end

# Skip formulae that are autobumped by BrewTestBot.
formulae_and_casks_to_check = formulae_and_casks_to_check.reject do |formula_or_cask|
next false if formula_or_cask.respond_to?(:token) # Only formulae are autobumped.
issyl0 marked this conversation as resolved.
Show resolved Hide resolved

autobump_file = formula_or_cask.tap.path/".github/autobump.txt"
next false unless File.exist?(autobump_file)

if File.read(autobump_file).include?(formula_or_cask.name)
odebug "Skipping #{formula_or_cask.name} as it is autobumped."
true

Check warning on line 102 in Library/Homebrew/dev-cmd/livecheck.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/dev-cmd/livecheck.rb#L102 

Added line #L102 was not covered by tests
end
issyl0 marked this conversation as resolved.
Show resolved Hide resolved
end

formulae_and_casks_to_check = formulae_and_casks_to_check.sort_by do |formula_or_cask|
formula_or_cask.respond_to?(:token) ? formula_or_cask.token : formula_or_cask.name
end
Expand Down
Loading