Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate_disable: typed: strict #18968

Merged
merged 2 commits into from
Dec 23, 2024
Merged

deprecate_disable: typed: strict #18968

merged 2 commits into from
Dec 23, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 20, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add more typing before working on #18661

@cho-m
Copy link
Member Author

cho-m commented Dec 20, 2024

Going to have to work around current JSON API output

  "deprecated": true,
  "deprecation_date": null,
  "deprecation_reason": "versioned_formula",
  "deprecation_replacement": null,
  "disabled": false,
  "disable_date": "2025-05-01",
  "disable_reason": null,
  "disable_replacement": null,

@cho-m cho-m force-pushed the deprecate_disable-type branch from fa28795 to bf040b0 Compare December 20, 2024 18:32
@cho-m cho-m force-pushed the deprecate_disable-type branch from bf040b0 to 21f3536 Compare December 20, 2024 18:33
@cho-m cho-m force-pushed the deprecate_disable-type branch from a153c9a to eebcd60 Compare December 20, 2024 19:30
@cho-m cho-m marked this pull request as ready for review December 20, 2024 19:41
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cho-m!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 23, 2024
Merged via the queue into master with commit 60f781f Dec 23, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the deprecate_disable-type branch December 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants