Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attestation: handle multiple subjects #18883

Merged
merged 3 commits into from
Dec 5, 2024
Merged

attestation: handle multiple subjects #18883

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5d47f8
attestation: handle multiple subjects
woodruffw Dec 5, 2024
9e82563
document the version that causes problems here
woodruffw Dec 5, 2024
057a6c5
add multi subject test
woodruffw Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Library/Homebrew/attestation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,10 @@ def self.check_attestation(bottle, signing_repo, signing_workflow = nil, subject

# `gh attestation verify` returns a JSON array of one or more results,
# for all attestations that match the input's digest. We want to additionally
# filter these down to just the attestation whose subject matches the bottle's name.
# filter these down to just the attestation whose subject(s) contain the bottle's name.
# As of 2024-12-04 GitHub's Artifact Attestation feature can put multiple subjects
woodruffw marked this conversation as resolved.
Show resolved Hide resolved
# in a single attestation, so we check every subject in each attestation
# and select the first attestation with a matching subject.
subject = bottle.filename.to_s if subject.blank?

attestation = if bottle.tag.to_sym == :all
Expand All @@ -175,12 +178,15 @@ def self.check_attestation(bottle, signing_repo, signing_workflow = nil, subject
# This is sound insofar as the signature has already been verified. However,
# longer term, we should also directly attest to `:all`-tagged bottles.
attestations.find do |a|
actual_subject = a.dig("verificationResult", "statement", "subject", 0, "name")
actual_subject.start_with? "#{bottle.filename.name}--#{bottle.filename.version}"
candidate_subjects = a.dig("verificationResult", "statement", "subject")
candidate_subjects.any? do |candidate|
candidate["name"].start_with? "#{bottle.filename.name}--#{bottle.filename.version}"
end
end
else
attestations.find do |a|
a.dig("verificationResult", "statement", "subject", 0, "name") == subject
candidate_subjects = a.dig("verificationResult", "statement", "subject")
candidate_subjects.any? { |candidate| candidate["name"] == subject }
end
end

Expand Down
Loading