Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow font install on linux #18874

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Dec 4, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should disable quarantine on Linux, allow installing fonts and set a location for the fonts. Marking this as draft until I've had a moment to test it.

Waiting for #18808 to be merged

@SMillerDev SMillerDev force-pushed the feat/cask/font_install branch 3 times, most recently from 801829e to e5c2c8c Compare December 5, 2024 08:11
@SMillerDev SMillerDev changed the title feat: only block cask install on Linux feat: allow font install on linux Dec 9, 2024
@SMillerDev SMillerDev force-pushed the feat/cask/font_install branch from e5c2c8c to d1b5f68 Compare December 14, 2024 14:30
@SMillerDev
Copy link
Member Author

Installing fonts now works, although it is still installing in the macOS location. I can't get the DEFAULTS to work.

@SMillerDev SMillerDev force-pushed the feat/cask/font_install branch 3 times, most recently from 99e0454 to ed30ba7 Compare December 14, 2024 15:14
@SMillerDev SMillerDev force-pushed the feat/cask/font_install branch from ed30ba7 to 378ff7c Compare December 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant