implement --map option #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +24,8 @@ import Data.Text (Text) | |||
| import Control.Monad.Reader (MonadReader, ReaderT, runReaderT, asks) | |||
| import Control.Monad.IO.Class (MonadIO) | |||
|
|
|||
| type BoardId = String | |||
There was a problem hiding this comment.
What about using a Text based newtype ?
There was a problem hiding this comment.
That would be fine, too. I only needed to specify things like "--map m1" so I just reached for a String.
It seems that the REST API allows you to specify a complete custom map. If that is the case did you have any ideas on how that would be expressed via the command line options?
There was a problem hiding this comment.
Maybe we can specify the path to a file and/or read from the stdin.
There was a problem hiding this comment.
Hmmm, perhaps I was wrong about being able to send a custom map - will have to check with the devs. But if it is possible then reading it from a file or stdin would be a good option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the --map option so that you can use the predefined maps m1, m2, etc.
For example: