defensively handle dup keys in cache

Heliosearch · Mar 10, 2014 · 05f6c83 · 05f6c83
1 parent 67cfdc0
commit 05f6c83
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/solr/core/src/java/org/apache/solr/util/ConcurrentLRUCache.java b/solr/core/src/java/org/apache/solr/util/ConcurrentLRUCache.java
@@ -492,7 +492,11 @@ public Map<K,V> getLatestAccessedItems(int n) {
       markAndSweepLock.unlock();
     }
     for (CacheEntry<K,V> e : tree) {
-      result.put(e.key, e.value);
+      V prev = result.put(e.key, e.value);
+      if (prev instanceof RefCount) {
+        // Can be hit with ant test -Dtest=TestFiltering -Dtests.seed=5112224A7DAF7DD46
+        ((RefCount)prev).decref();
+      }
     }
     return result;
   }