-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding audiobook script #1407
Adding audiobook script #1407
Conversation
👇 Click on the image for a new way to code review
Legend |
Please merge it after 31 October. |
That's possible, but can I ask what the reason is for this request? (Sorry if I am a little too curious). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is just like an example and documentation for the audiobook library. This is a repository for useful scripts and not a place to promote self-created libraries.
My point here is mainly the README.md
. It's just the same as audiobooks README.md
. But it shouldn't be that. The README.md
for this script should be about the the script that you want to add and not about the library behind it.
You can also read about this in the STYLE_GUIDELINES.md
under section "Prerequisites".
If you need inspiration for the README.md
take a look at TEMPLATE_README.md
file.
script.py
itself looks OK to me.
Thanks for pointing out the issues. I will make the necessary changes. |
I am participating in Hacksquad so I can only make quality PR. Otherwise, I can be disqualified. That's why I was asking to merge it after 31st October. |
As I reviewed this PR the first time I thought that this would be a very cool addition to the project.
You state yourself that this is not a quality PR. And even if I think this script would be worth adding, I don't think this project aims to be a collections basin for unqualitative PRs and scripts. |
but it's a very helpful script to convert the book to audio format. so, In my opinion, it's worth it. I mentioned the quality PR which means contributions to the collections repo and DSA repo are not allowed |
Following this argument, you already should be disqualified for opening PRs in awesomeScripts as this is basically the same as this project. So I personally don't see any reason for not merging it before 31. October. |
I got warnings for that. No issue you can merge it. |
I didn't no this. Now the situation is understandable, I guess this doesn't gonna get merged before 31st October. |
Thanks @ClasherKasten |
Description
Added a script to Read Book in audiobook folder.
Fixes #1406
Type of change
Checklist:
README.md