Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return details for steps that faulted on the worker #37

Merged
merged 13 commits into from
Dec 10, 2023
Merged

Return details for steps that faulted on the worker #37

merged 13 commits into from
Dec 10, 2023

Conversation

db0
Copy link
Member

@db0 db0 commented Dec 8, 2023

No description provided.

@tazlin
Copy link
Member

tazlin commented Dec 8, 2023

The issues that remain are bona-fide issues to do with typing. I recommend running mypy and seeing what you can do about resolving any of the issues before I get a chance to look at this closer.

@db0 db0 marked this pull request as ready for review December 9, 2023 16:01
Copy link
Member

@tazlin tazlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code runs locally for me overnight with no incident.
  • The changes in this PR are straightforward and conform to the preexisting paradigms.

@tazlin tazlin merged commit a58925a into main Dec 10, 2023
1 check passed
@db0 db0 deleted the frep branch December 28, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants