Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of config file in container #315

Draft
wants to merge 1 commit into
base: raw-png
Choose a base branch
from

Conversation

HPPinata
Copy link

@HPPinata HPPinata commented Oct 6, 2024

This logic checks whether bridgeData.yaml has been mapped to it's standard location.
If it finds a file there, it uses it instead of relying on env variables.

Apart from ENV variables this is the other common way of importing dynamic configuration into a container.
It comes with the advantage of not having to recreate the container to change the config and not having to convert anything, at the expense of having two state files (compose and bridgeData) and having to do a bindmount.

This should work, but hasn't been tested extensively, thus the draft.
Depending on whether this, or the ROCm Dockerfile are merged first I'll update the correct pull request to match the others status.

I should also update the documentation to reflect that this is an option.

This logic checks whether bridgeData.yaml has been mapped to it's standard location.
If it finds a file there, it uses it instead of relying on env variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant