allow use of config file in container #315
Draft
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic checks whether bridgeData.yaml has been mapped to it's standard location.
If it finds a file there, it uses it instead of relying on env variables.
Apart from ENV variables this is the other common way of importing dynamic configuration into a container.
It comes with the advantage of not having to recreate the container to change the config and not having to convert anything, at the expense of having two state files (compose and bridgeData) and having to do a bindmount.
This should work, but hasn't been tested extensively, thus the draft.
Depending on whether this, or the ROCm Dockerfile are merged first I'll update the correct pull request to match the others status.
I should also update the documentation to reflect that this is an option.