Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Gifted shirt coupons #438

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

fridaland
Copy link
Contributor

@fridaland fridaland commented Nov 14, 2019

Add ability to gift shirts to incompleted users

In #437 we added the ability to gift sticker_coupons. This pull request will allow users to receive "gifted" t-shirt coupons as well.

Test process

Currently, we only allow completed users to receive shirt coupons.

Changes necessary:

  • Update this rake task to reflect giving users any remaining available shirt coupons when that is implemented in CouponService
  • Update CouponService to allow incompleted users to receive shirt coupons.
  • Ensure pending coupon_service_specs are no longer pending
  • Add a context in user_spec for there are shirt coupons available

Requirements to merge

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

fridaland and others added 30 commits November 13, 2019 10:27
@fridaland fridaland changed the title Gifted shirt coupons WIP - Gifted shirt coupons Nov 14, 2019
@fridaland
Copy link
Contributor Author

fridaland commented Nov 14, 2019

This will need to be rebased against master once #437 is merged.

@fridaland fridaland force-pushed the gifted-shirt-coupons branch from abfa362 to 6fbe884 Compare November 14, 2019 23:24
@fridaland
Copy link
Contributor Author

Screen Shot 2019-11-14 at 6 29 48 PM

@fridaland fridaland changed the title WIP - Gifted shirt coupons Gifted shirt coupons Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants