Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加启动动画 #3442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

添加启动动画 #3442

wants to merge 2 commits into from

Conversation

Glavo
Copy link
Member

@Glavo Glavo commented Nov 10, 2024

QQ20241111-31452-HD.mp4

@Glavo Glavo changed the title 在 Windows 平台添加启动动画 添加启动动画 Nov 10, 2024
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current commit doesn't seem to work on Windows...

@Glavo
Copy link
Member Author

Glavo commented Nov 12, 2024

The current commit doesn't seem to work on Windows...

我这里很正常。你的动画开关是开着的吗?

@3gf8jv4dv
Copy link
Contributor

3gf8jv4dv commented Nov 12, 2024

我这里很正常。你的动画开关是开着的吗?

Yes. I did not disable the animation.

I have found that it seems to be related to the number or type of fonts installed on the system. At the time I had Sarasa Gothic (variant used), Source Han Serif (variant used), and Source Han Sans (variant used) installed on my host.

When I have installed the entire family of these fonts, the launcher does not show the startup animation when choosing some fonts in the launcher. For example, when Tahoma is chosen, the launcher will show a startup animation. When default or Segoe UI is chosen, there is no startup animation.

After I uninstalled those fonts, I was pleasantly surprised to notice that the animation came back — no matter what font was chosen.

@zkitefly
Copy link
Member

record.2.webm

@3gf8jv4dv
Copy link
Contributor

Upon further testing, I realized that the more fonts I installed, the less or even no animation effect. This is true even for multiple variants of the same font family. Is there any possibility of optimization for this? I think there will always be people who have tons of fonts installed on their system for various reasons.


I have a few minor comments about the current animations. I cannot say why exactly, but I think the previous few commits worked better and looked smoother and silkier.

@burningtnt
Copy link
Member

??? WHAT ???
I think it a strange bug on JavaFX. I'll check the source code to see if anything is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants