Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling check for prop types. #20623

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

Starting with React 19, propTypes will not be checked anymore. We are relying on TypeScript for props checking for quite a while now and while additional runtime checks sound desirable in theory, the track record of issues caught through them is close to zero. Therefore, we are disabling the linter rule checking for their existence and new components should be written without them.

/nocl No user-facing change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant