Migrating various tests from enzyme to testing-library.

Graylog2 · Oct 2, 2024 · af3c30b · af3c30b
1 parent 5e0e886
commit af3c30b
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 24 deletions.
diff --git a/...nt-packs/ContentPackEntityConfig.test.jsx → ...nt-packs/ContentPackEntityConfig.test.tsx b/...nt-packs/ContentPackEntityConfig.test.jsx → ...nt-packs/ContentPackEntityConfig.test.tsx
@@ -15,13 +15,13 @@
  * <http://www.mongodb.com/licensing/server-side-public-license>.
  */
 import React from 'react';
-import { mount } from 'wrappedEnzyme';
+import { render, screen } from 'wrappedTestingLibrary';
 import 'helpers/mocking/react-dom_mock';
 
 import ContentPackEntityConfig from 'components/content-packs/ContentPackEntityConfig';
 
 describe('<ContentPackEntityConfig />', () => {
-  it('should render with a entity', () => {
+  it('should render with a entity', async () => {
     const entity = {
       data: {
         title: { '@type': 'string', '@value': 'franz' },
@@ -30,10 +30,11 @@ describe('<ContentPackEntityConfig />', () => {
     };
     const appliedParameter = [{ configKey: 'descr', paramName: 'descrParam' }];
     const parameter = [{ name: 'descrParam', title: 'A descr Parameter', type: 'string' }];
-    const wrapper = mount(<ContentPackEntityConfig entity={entity}
-                                                   appliedParameter={appliedParameter}
-                                                   parameters={parameter} />);
 
-    expect(wrapper).toExist();
+    render(<ContentPackEntityConfig entity={entity}
+                                    appliedParameter={appliedParameter}
+                                    parameters={parameter} />);
+
+    await screen.findByText(/franz/i);
   });
 });
diff --git a/...-packs/ContentPackUploadControls.test.jsx → ...-packs/ContentPackUploadControls.test.tsx b/...-packs/ContentPackUploadControls.test.jsx → ...-packs/ContentPackUploadControls.test.tsx
@@ -15,15 +15,15 @@
  * <http://www.mongodb.com/licensing/server-side-public-license>.
  */
 import React from 'react';
-import { mount } from 'wrappedEnzyme';
+import { render, screen } from 'wrappedTestingLibrary';
 import 'helpers/mocking/react-dom_mock';
 
 import ContentPackUploadControls from 'components/content-packs/ContentPackUploadControls';
 
 describe('<ContentPackUploadControls />', () => {
-  it('should render', () => {
-    const wrapper = mount(<ContentPackUploadControls />);
+  it('should render', async () => {
+    render(<ContentPackUploadControls />);
 
-    expect(wrapper).toExist();
+    await screen.findByRole('button', { name: /upload/i });
   });
 });
diff --git a/...s/grok-patterns/EditPatternModal.test.jsx → ...s/grok-patterns/EditPatternModal.test.tsx b/...s/grok-patterns/EditPatternModal.test.jsx → ...s/grok-patterns/EditPatternModal.test.tsx
@@ -15,26 +15,26 @@
  * <http://www.mongodb.com/licensing/server-side-public-license>.
  */
 import React from 'react';
-import { mount } from 'wrappedEnzyme';
+import { render, screen } from 'wrappedTestingLibrary';
 import 'helpers/mocking/react-dom_mock';
 
 import EditPatternModal from 'components/grok-patterns/EditPatternModal';
 
 describe('<EditPatternModal />', () => {
-  it('should render a modal button with as edit', () => {
-    const wrapper = mount(<EditPatternModal savePattern={() => {}}
-                                            testPattern={() => {}}
-                                            validPatternName={() => {}} />);
+  it('should render a modal button with as edit', async () => {
+    render(<EditPatternModal savePattern={() => {}}
+                             testPattern={() => {}}
+                             validPatternName={() => {}} />);
 
-    expect(wrapper).toExist();
+    await screen.findByRole('button', { name: /edit/i });
   });
 
-  it('should render a modal button with as create', () => {
-    const wrapper = mount(<EditPatternModal create
-                                            savePattern={() => {}}
-                                            testPattern={() => {}}
-                                            validPatternName={() => {}} />);
+  it('should render a modal button with as create', async () => {
+    render(<EditPatternModal create
+                             savePattern={() => {}}
+                             testPattern={() => {}}
+                             validPatternName={() => {}} />);
 
-    expect(wrapper).toExist();
+    await screen.findByRole('button', { name: /create pattern/i });
   });
 });
diff --git a/...g2-web-interface/src/views/components/aggregationbuilder/EmptyAggregationContent.test.tsx b/...g2-web-interface/src/views/components/aggregationbuilder/EmptyAggregationContent.test.tsx
@@ -15,7 +15,7 @@
  * <http://www.mongodb.com/licensing/server-side-public-license>.
  */
 import * as React from 'react';
-import { mount } from 'wrappedEnzyme';
+import { render } from 'wrappedTestingLibrary';
 
 import EmptyAggregationContent from './EmptyAggregationContent';
 
@@ -25,7 +25,7 @@ describe('EmptyAggregationContext', () => {
   it('calls render completion callback after first render', () => {
     const onRenderComplete = jest.fn();
 
-    mount((
+    render((
       <RenderCompletionCallback.Provider value={onRenderComplete}>
         <EmptyAggregationContent toggleEdit={() => {}} editing={false} />
       </RenderCompletionCallback.Provider>