Feat clipboard access #503
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octocorvus
force-pushed
the
feat-clipboard-access
branch
from
fdf36c3
to
6ce6622
Compare
muhomorr
reviewed
Mar 23, 2024
services/core/java/com/android/server/clipboard/ClipboardService.java
Outdated
Show resolved
Hide resolved
services/core/java/com/android/server/clipboard/ClipboardService.java
Outdated
Show resolved
Hide resolved
octocorvus
force-pushed
the
feat-clipboard-access
branch
4 times, most recently
from
8d98122
to
90a76b1
Compare
octocorvus
force-pushed
the
feat-clipboard-access
branch
4 times, most recently
from
45ce741
to
f5f693b
Compare
octocorvus
force-pushed
the
feat-clipboard-access
branch
from
03270e5
to
d85cc09
Compare
thestinger
force-pushed
the
14
branch
6 times, most recently
from
c151c14
to
26e77ce
Compare
thestinger
force-pushed
the
14
branch
2 times, most recently
from
af7c305
to
ebb62a9
Compare
Previously I set this to null, but this can cause a NPE
Signed-off-by: r3g_5z <[email protected]>
Ported from 11, 12 moved the isLogoutEnabled boolean to ActiveAdmin.java
Bug: 329205638 Test: pm set-user-restriction --user 0 no_config_brightness 1 Flag: ACONFIG com.android.systemui.enforce_brightness_base_user_restriction DEVELOPMENT (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f9f3fdba4b4995b0ca45732b95de64318642e210) Merged-In: I47b8b72a5a5c4098b46f0b5dbbf0654513b03aee Change-Id: I47b8b72a5a5c4098b46f0b5dbbf0654513b03aee
RestrictedLockUtils#getShowAdminSupportDetailsIntent signature change such that it no longer requires a context. Flag: NA Bug: 138786270 Test: built and flashed (cherry picked from commit 4db275f0e5709bf94c13e6fee06cd90d83e1c988) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:50341746d3b69ba34033e863c9f53c30c56aaa44) Merged-In: If4ab3030cfa1f9faed5d099077e5e3bab2cba622 Change-Id: If4ab3030cfa1f9faed5d099077e5e3bab2cba622
This upstream feature checks that signatures of updated system apps verify against signatures of the corresponding system apps. Such checks are already performed downstream as part of PackageVerityExt, this upstream feature is an extra layer of protection.
Previously, ACCESS_KEYGUARD_SECURE_STORAGE permission was enough to check that. Presence of duress password is intended to be unknown unless the owner credential is provided. This was enforced in the UI layer (Settings app) already, but could be bypassed through UI bugs, such as the recently patched predictive back gesture bug: GrapheneOS/platform_packages_apps_Settings@e6ac6fa
octocorvus
force-pushed
the
feat-clipboard-access
branch
2 times, most recently
from
1bb59de
to
c95545b
Compare
Directory can be removed by the time listFiles() is called, which makes it return null. Null can also be returned due to an I/O error.
octocorvus
force-pushed
the
feat-clipboard-access
branch
from
c95545b
to
f41869c
Compare
thestinger
force-pushed
the
14
branch
3 times, most recently
from
edb3b08
to
6aa5c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation for denying clipboard read access on a per-app basis. As of now, there isn't a way to explicitly paste clipboard content, so this feature is disabled by default, and can be turned on using the clipboard setting in the privacy section.
Depends On:
GrapheneOS/platform_packages_apps_Settings#236