Add downloads samples #934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The special thing is that eval was used before download_filename_controller to support writing js to modify the name of the downloaded file, but this cannot be used in MV3. |
oliverdunk
requested changes
Aug 25, 2023
api-samples/downloads/download_filename_controller/service-worker.js
Outdated
Show resolved
Hide resolved
jpmedley
suggested changes
Aug 25, 2023
api-samples/downloads/download_filename_controller/manifest.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Medley <[email protected]>
|
READMEs and Descriptions: LGTM |
jpmedley
reviewed
Aug 28, 2023
Co-authored-by: Joe Medley <[email protected]>
jpmedley
suggested changes
Aug 28, 2023
jpmedley
approved these changes
Feb 6, 2024
|
Could you add the example for download open. I could not using it currently |
Shikho18
approved these changes
Nov 27, 2024
| suggest({ | ||
| filename: item.filename, | ||
| conflictAction: 'overwrite' | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.