Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LevelID as ArcGIS cache gridset's name #961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

initialdmg
Copy link

Arcgis cache layer extension does not assign any scale name to gridsets, so GridSetFactory make it as gridsetName:i , like EPSG:4326_arcgis:0. This patch use levelID, like 0, 1, 2 ..., as scaleName, and it is correspond with our practice in WMTS.

@aaime
Copy link
Member

aaime commented May 3, 2021

I agree many tools struggle with gridsets names that are not numeric. It is unfortunate, as the WMTS the specification poses no such constraint, but best to align with what works in practice.

However, this change should have a unit or integration test covering the change, please add one.

@initialdmg initialdmg force-pushed the arcgis-cache-layer branch 2 times, most recently from 722f4db to b27e5b4 Compare May 10, 2021 03:31
@initialdmg
Copy link
Author

Code committed earlier was an idea, and was not edited in editor, sry for this behaviour. To keep timeline clear, i force pushed the right code and test case, which has passed on my machine. You can review the code now 😃

@smithkm smithkm closed this Oct 3, 2021
@smithkm smithkm reopened this Oct 3, 2021
@jodygarnett
Copy link
Contributor

Has this PR become stale? Request a rebase as some time has passed.

@jodygarnett
Copy link
Contributor

This is the only outstanding PR that would make a new 1.22.x interesting; but the PR appears stale?

@aaime
Copy link
Member

aaime commented Jul 15, 2024

@smithkm what should we do regarding this PR? It's old but seems mergeable. Pheraps it should be rebased to make sure the builds are all still working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants