-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spreadsheet view refactor to use @mui/x-data-grid component and volatile storage #4047
Draft
cmdcolin
wants to merge
4
commits into
main
Choose a base branch
from
spreadsheetview_volatile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Nov 6, 2023
cmdcolin
added
enhancement
New feature or request
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Nov 6, 2023
possible alternative: leave the existing spreadsheet view as-is to avoid any breaking behavior, and make this a new view type, however, then we have two things for ongoing maintenance |
small bonus endeavor: adding #788 splitting out VCF INFO column into multiple filterable/sortable columns |
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
November 6, 2023 15:50
e0710f6
to
e09e5c9
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
December 3, 2023 15:22
83c55ee
to
f7dd8e3
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
December 13, 2023 19:19
8e1da47
to
7f7c6f8
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
January 10, 2024 17:56
7f7c6f8
to
6543aba
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
January 19, 2024 17:34
6543aba
to
faee91c
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
February 21, 2024 19:50
dd4d2f9
to
dbe6b86
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
March 14, 2024 17:48
66f78f6
to
cae4f0e
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
April 18, 2024 16:57
cae4f0e
to
ebc2e25
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
June 4, 2024 18:30
ebc2e25
to
3c1af1b
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
June 17, 2024 15:24
37c4db4
to
afba15a
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
August 1, 2024 22:25
afba15a
to
6f77f35
Compare
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
2 times, most recently
from
September 19, 2024 18:14
d56f7f1
to
5a0b3f7
Compare
Remove [skip ci] Volatile [skip ci] Parse out INFO field [skip ci] Misc Misc Restyling Refactoring More misc Misc Misc Misc Misc New Refname renaming fix for breakpoint split view Breakpoint split view Misc [skip ci] Refactors Use 7.0.0 Updates Misc Misc Misc SV inspector working
cmdcolin
force-pushed
the
spreadsheetview_volatile
branch
from
September 24, 2024 15:27
5a0b3f7
to
075ed05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the spreadsheet view stores all data in the mobx-state-tree. This has a small convenience, but it lags very strongly for any reasonably sized data file loaded into it. A 33Mb VCF takes slows down a lot, taking up a lot of memory (which is a known issue mobxjs/mobx-state-tree#1683). This PR changes to loading directly from a volatile. With this PR, it loads the 33Mb VCF almost very fast, and takes up much less memory
There will require work to make this attain feature parity with existing spreadsheet view, but I believe it will be a valuable change