Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbus warning #136

Open
wants to merge 2 commits into
base: release_2_0
Choose a base branch
from
Open

Add dbus warning #136

wants to merge 2 commits into from

Conversation

ikreb7
Copy link
Contributor

@ikreb7 ikreb7 commented Oct 25, 2018

I think it would be nice if we give them a solution if the dbus python api is missing. What is your opinion?

@twoln
Copy link
Contributor

twoln commented Oct 25, 2018

That looks great, but perhaps we should ask the users whether they would like to install the package or generate the wpa_supplicant config file? Perhaps before we suggest installation we might try if nmcli is available and if so just use that. This would require some more code rearrangement, in fact we might start with searching for nmcli and only if we do not find it go for the dbus interface. Still this looks like a bit of a project.

@leon-richardt
Copy link

leon-richardt commented Mar 12, 2019

Yes, something should definitely done about this. Just failing without stating the reason is incredibly frustrating. Most users don't have the option of looking at the source and figuring out which package they are missing. (To be fair, most Linux users are probably savvy enough to be able to figure out a package is missing. The point still stands though!)

@ikreb7
Copy link
Contributor Author

ikreb7 commented Nov 8, 2019

That looks great, but perhaps we should ask the users whether they would like to install the package or generate the wpa_supplicant config file? Perhaps before we suggest installation we might try if nmcli is available and if so just use that. This would require some more code rearrangement, in fact we might start with searching for nmcli and only if we do not find it go for the dbus interface. Still this looks like a bit of a project.

See #162. I add nmcli. So maybe we could drop using dbus soon.

@XI2vGMst
Copy link

XI2vGMst commented Sep 8, 2024

Without this pr, my script just resorts back to wpa_supplicant without even giving a proper explanation. It took me like 2 hours to figure out that a package was missing. I found the issue because I just set NM_AVAILABLE to True and then it finally gave me the warning that the package isn't installed.

I want this to be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants