Update the WASM compatibility tests for 0.36 release
#2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-ch
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
xgreenx
reviewed
Oct 1, 2024
| @@ -47,15 +47,14 @@ async fn latest_binary_is_backward_compatible_and_can_load_testnet_config() { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn latest_binary_is_backward_compatible_and_follows_blocks_created_by_genesis_binary( | |||
| ) { | |||
| async fn latest_binary_is_backward_compatible_and_follows_blocks_created_by_v36_binary() { | |||
There was a problem hiding this comment.
It still would be nice to have one more backward compatibility tests that produces blocks by fuel-core 0.26.0
There was a problem hiding this comment.
Genesis test is restored in 13f2653
…created_by_genesis_binary()` test
rymnc
previously approved these changes
Oct 3, 2024
xgreenx
reviewed
Oct 3, 2024
Comment on lines
136
to
137
| "--snapshot", | ||
| IGNITION_TESTNET_SNAPSHOT, |
There was a problem hiding this comment.
This snapshot using the state transition function from fuel-core 0.26.0. Maybe we want to add a new snapshot for fuel-core 0.36?=)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2198.
Description
This test upgrades the forward compatibility test by replacing the "genesis" nodes (which used v0.26) with the nodes that use v36 of the client.
It also adds one backward compatibility test:
latest_binary_is_backward_compatible_and_follows_blocks_created_by_v36_binary()Before requesting review