-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provisioning: Prevent re-provisioning #94
base: main
Are you sure you want to change the base?
provisioning: Prevent re-provisioning #94
Conversation
After successful provisioning, the code writes a pattern into the ITS, which could be checked on the next boot. Signed-off-by: Dávid Házi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine - minor comments.
|
||
if( status != PSA_SUCCESS ) | ||
/* FIXME: Magic value */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment going to be addressed? I see it in each main.c.
|
||
if( status != PSA_SUCCESS ) | ||
{ | ||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment - I notice in calls to this function you check if it returns "false" and not 0. Should this function return "false" and "true" ?
After successful provisioning, the code writes a pattern into the ITS, which could be checked on the next boot.
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.