Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish_node_package): do not checkout to working_directory #73

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

ppawlowski
Copy link
Collaborator

Description

This pull request fixes the code checkout step in Build and publish npm package reusable workflow. Fix assures, that checkout is not made to the directory specified in the working_directory input since this approach breaks the possibility to build packages located in subdirectory.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit dacea63 into main Oct 4, 2024
@hardillb hardillb deleted the fix-separate-checkout-workdir branch October 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants