Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor container image build workflow #68

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat: Refactor container image build workflow #68

merged 2 commits into from
Sep 9, 2024

Conversation

ppawlowski
Copy link
Collaborator

Description

This pull request refactors Build container image reusable workflow by:

  • building single-platform image
  • removing matrix strategy approach
  • replacing image pull from private registry with a load parameter of docker/build-push-action action
  • introducing workflow image output to be consumed by external actions/workflows
  • organising inputs list in a alphabetical order

Related Issue(s)

FlowFuse/helm#456

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

hardillb
hardillb approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please point me at the part where the node-red container is built for ARM64 overwriting the default.

.github/workflows/build_container_image.yml Show resolved Hide resolved
@ppawlowski ppawlowski merged commit 1e7280d into main Sep 9, 2024
@ppawlowski ppawlowski deleted the feat-refactor-image-build branch September 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppawlowski @hardillb