Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at S3 tests #44

Closed
wants to merge 9 commits into from
Closed

First pass at S3 tests #44

wants to merge 9 commits into from

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 23, 2022

Description

Uses minio to provide S3 bucket.

Running locally

docker pull minio/minio
mkdir -p var/data/test
docker run --rm -v `pwd`/var/data:/data -p 9000:9000 minio/minio server /data

Related Issue(s)

#40

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Uses minio to provide S3 bucket.

Running locally

```
docker pull minio/minio
mkdir -p var/data/test
docker run --rm -v `pwd`/var/data:/data -p 9000:9000 minio/minio server
/data
```
@Steve-Mcl Steve-Mcl marked this pull request as ready for review December 23, 2022 13:28
@hardillb
Copy link
Contributor Author

Basic test now run with S3 on GitHub

@Steve-Mcl Steve-Mcl linked an issue Dec 23, 2022 that may be closed by this pull request
@Steve-Mcl
Copy link
Contributor

@hardillb with new file system stuff and other progress, perhaps we should close this off for the time being?

@hardillb
Copy link
Contributor Author

I'll fix the conflict and we can just merge it, but yes this code will get phased out soon.

@hardillb
Copy link
Contributor Author

Hmm, bunch of none S3 test failures....

@hardillb hardillb closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for s3 backend storage
2 participants