Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #356, multiple class adapted for the feature. #357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

perilbrain
Copy link

@perilbrain perilbrain commented Aug 17, 2019

(fix for #356)

  • Accepts new annotation for collection type.

Hey I have made a few improvements to fix the issue. All tests cases are passing but I definitely need a review for this commit.

- Accepts new annotation for collection type.
@perilbrain perilbrain changed the title Fix for #336, multiple class adapted for the feature. Fix for #356, multiple class adapted for the feature. Aug 18, 2019
This functional usually called from the factories of various frameworks like spring needs to resolve the the type of `value` directly rather than trying to figure parameter of some generic.
@cowtowncoder
Copy link
Member

Ah, this looks good I think; I will try to go through with it in more detail, but wanted to mention that this is on my radar for things to go in 2.10 (but I'm also bit overload with all changes :) ).

Only one more question: have I already asked for CLA? If not, it's here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and we'd need a filled copy before first merged contribution (apologies if I have already asked and gotten one).
Easiest way usually is to print it, fill & sign, scan, email to info at fasterxml dot com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants