Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adds brotli compression with gzip fallback" #203

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

rosschapman
Copy link
Collaborator

@rosschapman rosschapman commented Sep 16, 2024

Reverts #200

Oops, learned the hard way that heroku does not support brotli compression in their nginx build pack yet. See: heroku/heroku-buildpack-nginx#109

From logs:

2024-09-16T18:18:34.926620+00:00 app[web.1]: nginx: [warn] the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:2
2024-09-16T18:18:34.926889+00:00 app[web.1]: 2024/09/16 18:18:34 [emerg] 2#2: unknown directive "brotli" in /etc/nginx/conf.d/default.conf:38
2024-09-16T18:18:34.926889+00:00 app[web.1]: nginx: [emerg] unknown directive "brotli" in /etc/nginx/conf.d/default.conf:38
2024-09-16T18:18:34.963929+00:00 heroku[web.1]: Process exited with status 1
2024-09-16T18:18:34.988087+00:00 heroku[web.1]: State changed from starting to crashed
2024-09-16T18:43:45.476437+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=our415-abb7eecb7449.herokuapp.com request_id=27847239-392b-4285-ba8f-4f3d81bf76c0 fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:43:45.667867+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=our415-abb7eecb7449.herokuapp.com request_id=096eeba2-0f04-462a-b88d-ca56cb08d3dc fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:43:46.949003+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=our415-abb7eecb7449.herokuapp.com request_id=53986a9d-0283-412c-8b50-04c9af21a8f6 fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:46:48.497980+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=our415-abb7eecb7449.herokuapp.com request_id=a9272d5b-bbcc-4a90-a20d-8e5391f4efdd fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:46:48.702466+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=our415-abb7eecb7449.herokuapp.com request_id=24dadf4b-e2a8-4f47-b4fe-13a59d146643 fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
Disconnected from log stream. There may be events happening that you do not see here! Attempting to reconnect...
2024-09-16T18:18:34.926620+00:00 app[web.1]: nginx: [warn] the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:2
2024-09-16T18:18:34.926889+00:00 app[web.1]: 2024/09/16 18:18:34 [emerg] 2#2: unknown directive "brotli" in /etc/nginx/conf.d/default.conf:38
2024-09-16T18:18:34.926889+00:00 app[web.1]: nginx: [emerg] unknown directive "brotli" in /etc/nginx/conf.d/default.conf:38
2024-09-16T18:18:34.963929+00:00 heroku[web.1]: Process exited with status 1
2024-09-16T18:18:34.988087+00:00 heroku[web.1]: State changed from starting to crashed
2024-09-16T18:43:45.476437+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=our415-abb7eecb7449.herokuapp.com request_id=27847239-392b-4285-ba8f-4f3d81bf76c0 fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:43:45.667867+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=our415-abb7eecb7449.herokuapp.com request_id=096eeba2-0f04-462a-b88d-ca56cb08d3dc fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:43:46.949003+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=our415-abb7eecb7449.herokuapp.com request_id=53986a9d-0283-412c-8b50-04c9af21a8f6 fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:46:48.497980+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=our415-abb7eecb7449.herokuapp.com request_id=a9272d5b-bbcc-4a90-a20d-8e5391f4efdd fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https
2024-09-16T18:46:48.702466+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=our415-abb7eecb7449.herokuapp.com request_id=24dadf4b-e2a8-4f47-b4fe-13a59d146643 fwd="72.70.49.145" dyno= connect= service= status=503 bytes= protocol=https

@rosschapman rosschapman merged commit e278de4 into main Sep 16, 2024
1 check passed
@rosschapman rosschapman deleted the revert-200-brotli-compression branch September 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant