Option to disable FSI ramping parameters #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3 booleans to disable the fsi ramping - `enable_temporal_ramping: false` - `enable_span_ramping: false` - `enable_theta_ramping: false`
psakievich
requested review from
ndevelder,
gantech,
lawrenceccheung and
ashesh2512
ashesh2512
approved these changes
Sep 15, 2023
|
no input decks are backwards compatible? Or they are all backward compatible, since these are optional? |
|
they are all backwards compatible. all old input decks will still run without these parameters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3 booleans to disable the fsi ramping for split meshes with gaps between the blades. In those cases we should no longer need to ramp spatially. We should keep temporal ramping on always except for targeted tests, but this gives a clear way to turn it off.
enable_temporal_ramping: falseenable_span_ramping: falseenable_theta_ramping: falseAll of these are defaulted to
trueand they are optional parameters i.e. no input decks are backwards compatible.