Checkpoint tools #885
Merged
Checkpoint tools #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* no changes other than names
* may remove and just modify IOManager
* it works!!! * checked against PlotfileToCSV routine
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
marchdf
reviewed
Jul 25, 2023
| } | ||
|
|
||
| [[nodiscard]] const DistributionMapping& | ||
| DistributionMap(int level) const noexcept |
There was a problem hiding this comment.
totally minor: you seem to be following camelCase for all the other member functions but this one.
There was a problem hiding this comment.
true! this is straight from "amrex/Src/Base/AMReX_PlotFileDataImpl.H" though
marchdf
reviewed
Jul 25, 2023
|
|
||
| virtual ~CoarsenCheckpt() = default; | ||
|
|
||
| void read_chkpt_add_baselevel(); |
There was a problem hiding this comment.
and these are snake case ;)
There was a problem hiding this comment.
I bet it does look funny with the different cases! But this PR has a few tools in it. CoarsenCheckpt is separate from CheckpointToCSV. Each is different because of the code I started from.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@marchdf are you good with these changes? |
marchdf
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools to