Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide NPH data in physical boundaries to advection calculation #1210

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Provide NPH data in physical boundaries to advection calculation #1210

wants to merge 20 commits into from

Commits on Oct 3, 2024

  1. update advection calls to also pass nph multifab of advected quantity… 

    … for sake of physbc
    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e1ba22c View commit details
    Browse the repository at this point in the history

  2. cleaning up MultiFab::Multiply calls

    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d34468f View commit details
    Browse the repository at this point in the history

  3. don't need time in vof_advection because fillphysbc isn't performed

    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    31d3d3f View commit details
    Browse the repository at this point in the history

  4. * use minimum number of ghost cells 

    * set temporary mfabs to 0 before filling bc
    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    89220c1 View commit details
    Browse the repository at this point in the history

  5. whoops format

    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    367726f View commit details
    Browse the repository at this point in the history

  6. put fillphysbc in level loop

    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f8d8e8b View commit details
    Browse the repository at this point in the history

  7. remove comment - Update amr-wind/equation_systems/AdvOp_Godunov.H 

    Co-authored-by: Marc T. Henry de Frahan <[email protected]>
    @mbkuhn @marchdf
    mbkuhn and marchdf committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    488757d View commit details
    Browse the repository at this point in the history

  8. remove another comment - Update amr-wind/equation_systems/AdvOp_Godun… 

    …ov.H

Co-authored-by: Marc T. Henry de Frahan <[email protected]>
    @mbkuhn @marchdf
    mbkuhn and marchdf committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    721cee0 View commit details
    Browse the repository at this point in the history

  9. changes that lead to the same result as before, but relying on nph fi… 

    …eld state and fillphysbc ahead of time
    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6e090ad View commit details
    Browse the repository at this point in the history

  10. fillphysbc at nph prior to MAC projection, update plane data after MA… 

    …C projection, avoid fillphysbc on old state within apply_bcs
    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ce6d1bc View commit details
    Browse the repository at this point in the history

  11. formatting

    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    97011fe View commit details
    Browse the repository at this point in the history

  12. again

    @mbkuhn
    mbkuhn committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b1ba25d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. add override

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4e2b851 View commit details
    Browse the repository at this point in the history

  2. remove new space

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a9eb12e View commit details
    Browse the repository at this point in the history

  3. setting up prepare_boundaries(), passes freestream_godunov

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    dd2e7d7 View commit details
    Browse the repository at this point in the history

  4. removing time argument; no longer needed

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    295959f View commit details
    Browse the repository at this point in the history

  5. formatting

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    305e5b8 View commit details
    Browse the repository at this point in the history

  6. returning a const

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bc471c1 View commit details
    Browse the repository at this point in the history

  7. formatting

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1dcc681 View commit details
    Browse the repository at this point in the history

  8. update pde unit test

    @mbkuhn
    mbkuhn committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a728a0a View commit details
    Browse the repository at this point in the history