Close prop on tab and tabBar #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gustavoFreireS
commented
Aug 16, 2019
gustavoFreireS
commented
- possible to have closeable prop on individual tabs and on the tabBar Allow "closeable" for individual tabs #38
davidcostadev
changed the title
| @@ -222,6 +222,9 @@ const TabBar = (props: TabBarProps) => { | |||
| {tabList.map((child: any, i) => { | |||
| const className = child.tabComponent.props.className; | |||
| const activeClassName = child.tabComponent.props.classNameActive; | |||
| const closeableTab = child.tabComponent.props.closeable | |||
There was a problem hiding this comment.
Why not use defaultProps?
There was a problem hiding this comment.
just missed it, definitely good to put it, in this case specifically, the props are inside the child component not on the parent itself, I defined the variables here for more readability when using it on the jsx after
| @@ -232,7 +235,7 @@ const TabBar = (props: TabBarProps) => { | |||
| onMouseUp={closeDragElement} | |||
| > | |||
| {child.tabComponent.props.tabHeader || child.tabComponent.props.text} | |||
| {props.closeable && | |||
| { shouldClose && | |||
| @@ -9,6 +9,7 @@ export interface TabProps { | |||
| text?: string; | |||
| className?: string; | |||
| classNameActive?: string; | |||
| closeable?: boolean; | |||
davidcostadev
suggested changes
Aug 16, 2019
| @@ -31,7 +31,7 @@ const TabInterface = () => { | |||
| </form> | |||
| </Tab> | |||
|
|
|||
| <Tab text="second tab" className="the-rest"> | |||
| <Tab text="second tab" > | |||
|
Please rebase this pull request |
|
@gustavoFreireS Could you review this PR again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.