Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

APP-6D Dismounted Individual Update #396

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

APP-6D Dismounted Individual Update #396

wants to merge 18 commits into from

Conversation

joebayles
Copy link
Collaborator

@joebayles joebayles commented Oct 26, 2017

Per APP-6(D).

Fixes #335 #339

@joebayles joebayles added this to the APP-6(D) milestone Oct 26, 2017
@joebayles joebayles changed the title Dismounted Individual Symbology APP-6D Dismounted Individual Symbology Oct 26, 2017
Copy link
Collaborator Author

@joebayles joebayles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No APP-6 Tag
  • Modifiers and Frames still have reference octagon

@joebayles joebayles changed the title APP-6D Dismounted Individual Symbology APP-6D Dismounted Individual Update Oct 27, 2017
Based on feedback from the UK
@csmoore
Copy link
Member

csmoore commented Jan 29, 2018

I was asked to test out the table/export apps for App6D, but I'm not able to get any of the apps(or unit tests) to work.

image

I get a parse error here (instance\Base.xml):
image

Even though that does look like a valid value (schema\core.xsd)
image

I'll keep looking into the source of the problem, but just wanted to check/confirm if @joebayles was able to run the demo apps on this branch.

@joebayles
Copy link
Collaborator Author

I didn't try, I didn't feel like I was 100% complete with necessary updates to the schema.

@csmoore
Copy link
Member

csmoore commented Jan 30, 2018

@joebayles - thanks - my bad - I didn't realize this PR + App6D was still a work in progress.

Just FYI, when you get back to, it looks like there may be some missing steps to recreate the code bindings from the schema (.xsd) when it changes. That is the issue above

@lfunkhouser - just let me know if you want me to spend any more time trying to get this export to work - if so, I might also need write access to the repo (I currently don't have)

@csmoore csmoore mentioned this pull request Jan 31, 2018
@csmoore
Copy link
Member

csmoore commented Jan 31, 2018

Fixes to this branch to get domains to export in #482 - that should be merged first.

I also noticed:

  1. Some of these icons don't seem to fit the frame for non-friendly

image

  1. The new leadership icon (below) - Amplifier 1, 2 (Digit 9 & 10) - value 71 - did not seem to be showing up in the exports

Speaking of which - the standard seems to have an error in the "Deputy Individual" value for this

image

  1. Numerous other issues with the frames, amplifiers, hqtffd icons on the new dismounted symbols set that would need to be researched/debugged further more to see where the problem lies.

@joebayles
Copy link
Collaborator Author

@csmoore now that we're talking more about this, I recall why I never finished, precisely these reasons.

Let's start raising issues in this repository, I can take them to the JSP in April.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants