fix(notice): ensure closed notice does not affect layout #10518
Merged
+53
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updates `openClose` test helper with option to assert on collapsed layout * adds util to get ElementHandle and updates applicable tests
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/10516-fix-notice-closed-layout-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10516
Summary
Fixes regression introduced by 7e2764f#diff-eef7cf73b4f6571be27053eba0e491f478a9569a26f5f2571a590a18bebfc591.
Noteworthy changes
openClosetest helper with option to assert on collapsed layoutElementHandleand updates applicable tests