Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice - content still occupies height after closed via close button #10516

Open
2 of 6 tasks
iyouth23 opened this issue Oct 9, 2024 · 1 comment
Open
2 of 6 tasks

Notice - content still occupies height after closed via close button #10516

iyouth23 opened this issue Oct 9, 2024 · 1 comment
Assignees
@geospatialem @DitwanP
Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2.13.1 patch

Comments

@iyouth23
Copy link

iyouth23 commented Oct 9, 2024

Check existing issues

Actual Behavior

After closing a calcite-notice with the close button, the notice's content itself still takes up space in the DOM, even though the content is hidden.

Expected Behavior

The notice's content should not take up space in the DOM.

Reproduction Sample

https://codepen.io/iyouth66/pen/ExqNZWR

Reproduction Steps

  1. Open this codepen: https://codepen.io/iyouth66/pen/ExqNZWR
  2. Close the calcite-notice via the close button. Observe that the wrapping div is still scrollable.

If you inspect the notice via Dev Tools before closing it, you will see that the shadow-root content is still occupying space after the notice is closed.

Reproduction Version

2.13.0

Relevant Info

Not reproducible before 2.12.0

Regression?

2.11.0

Priority impact

impact - p2 - want for an upcoming milestone

Impact

This seems similar to an older issue related to closed floating elements: #10240.

cc @geospatialem

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@iyouth23 iyouth23 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 9, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Oct 9, 2024
@jcfranco jcfranco added regression Issues that are caused by changes in a release, but were working before that. p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 9, 2024
@jcfranco jcfranco self-assigned this Oct 9, 2024
@jcfranco jcfranco added this to the 2.13.1 patch milestone Oct 9, 2024
@jcfranco jcfranco mentioned this issue Oct 10, 2024
Merged
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2.13.1 patch
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @iyouth23 @DitwanP